Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded Web Chat to 4.12.0 and fixed various Web Chat bugs #2236

Merged
merged 6 commits into from
Mar 3, 2021
Merged

Upgraded Web Chat to 4.12.0 and fixed various Web Chat bugs #2236

merged 6 commits into from
Mar 3, 2021

Conversation

tonyanziano
Copy link
Contributor

Description

  • Bumped Web Chat to 4.12.0
  • Integrated new useObserveTranscriptFocus() hook with the activity inspector
  • Updated web speech ponyfill to use correct API
  • Fixed a visual styling bug that was causing the Web Chat send box to be partially or fully hidden

Fixes #2234

Screenshots

New send box a11y highlighting:

wc-focus-light
wc-focus-dark
wc-focus-hc

corinagum
corinagum approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 67.802% when pulling 6089558 on toanzian/wc-bump into e16706f on main.

@tonyanziano tonyanziano merged commit 5e2ea09 into main Mar 3, 2021
@tonyanziano tonyanziano deleted the toanzian/wc-bump branch March 3, 2021 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@compulim compulim Awaiting requested review from compulim compulim is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

Assignees

@srinaath srinaath

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Input box disappears when content scrolls out of view port
4 participants
@tonyanziano @coveralls @corinagum @srinaath