Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#2398] Support Bots that use Single Tenant AAD Applications #2457

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #2398

Description

This PR enables the tenant id value to authenticate Emulator with Single Tenant apps.

This feature requires bots with the last updates of botbuilder-dotnet and botbuilder-js:
PR#6769
PR#4643

Specific Changes

  • Added tenantId property to the classes involved in authentication.
  • Added logic to get the access token for the Single Tenant login endpoint.
  • Added method to use tenant ID value to create a dynamic issuer.

Testing

These images show the new field Tenant ID in the Open Bot and New Bot Configuration views.
image
image

This is the new message error related to authentication.
image

The following image shows the Emulator working with a bot using Single Tenant authentication.
image

@coveralls
Copy link

coveralls commented Apr 5, 2024

Coverage Status

coverage: 67.547% (-0.004%) from 67.551%
when pulling c804d81 on southworks/add/support-singletenant-apps
into 012a664 on main.

JhontSouth and others added 2 commits April 5, 2024 11:32
…enant-apps' into southworks/add/support-singletenant-apps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Bots that use Single Tenant AAD Applications
3 participants