Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll to bottom feature does not differentiate between new messages and 'read' messages #1657

Closed
xinfli opened this issue Jan 29, 2019 · 8 comments
Labels
backlog Out of scope for the current iteration but it will be evaluated in a future release. front-burner

Comments

@xinfli
Copy link

xinfli commented Jan 29, 2019

The "New messages" always show when I scroll up, even I already read all messages.
Is it possible to mark all messages as read, or can I hide the "New messages"?
Thanks.

@corinagum
Copy link
Contributor

Hi @xinfli, the "New messages" notification actually indicates there are new messages at the bottom of the chat (most recent messages). Could you test and see if it disappears when you scroll to the bottom of the chat? Is this a feature you would still prefer to hide?

@corinagum corinagum added question Further information is requested. Stack Overflow candidate Pending labels Jan 29, 2019
@xinfli
Copy link
Author

xinfli commented Jan 29, 2019

Hi @corinagum Thanks, the notification works fine as design (When scroll to bottom, it will disapper), but not as I expected.
I think it should only indicate that there are new message UNREAD arrived, then I should scroll to bottom to read it;
But now the notification will always show when ever I scroll up, that makes us confused.
If this notification only indicate that I'm not reading the newest message, I think it should be renamed to "Go to bottom".

@corinagum
Copy link
Contributor

@xinfli, thanks for the details. :) While the team discusses this, please know that you are more than welcome to pick and choose the components you want to use. If the "New messages" button is a blocking feature for you, you can take it out if you wish. Please take a look at 13.customization-speech-ui for guidance on implementation.

Discussion

It sounds like there are potentially three issues here:

  1. "New messages" is syntactically inaccurate and better wording should be provided. A simple "Scroll to bottom" would more properly reflect the behavior of the button.
  2. If "New messages" IS the syntactically intended functionality, this component may be buggy and an 'unread' feature should be implemented.
    • I think both 1 and 2 would benefit from a discussion with design. @mewa1024, @DesignPolice do you have thoughts?
  3. Scroll to bottom button is customize-able, but text is not. @compulim and @cwhitten, is providing text modifications something we want to look into providing? With my limited knowledge this seems non-trivial.

@mewa1024
Copy link

I think issue 2 above is accurate, and that this should be the behavior: "New messages" should disappear once the new/unseen message has scrolled into view, but it should not reappear when that message scrolls out of view again.

@corinagum corinagum added bug Indicates an unexpected problem or an unintended behavior. backlog Out of scope for the current iteration but it will be evaluated in a future release. and removed Pending labels Jan 29, 2019
@DesignPolice
Copy link

I would agree with @mewa1024 as well.

@corinagum corinagum changed the title How to mark all message as read? Scroll to bottom feature does not differentiate between new messages and 'read' messages Jan 29, 2019
@corinagum
Copy link
Contributor

We've had more offline discussion -- this issue is related to compulim/react-scroll-to-bottom#10 - both issues will need to be resolved at the same time.

We want to have a 'read' marker where all messages are marked as read when the user hits the bottom of the container.

I'm keeping this issue open for tracking both.

@corinagum corinagum added front-burner Approved backlog Out of scope for the current iteration but it will be evaluated in a future release. and removed bug Indicates an unexpected problem or an unintended behavior. backlog Out of scope for the current iteration but it will be evaluated in a future release. question Further information is requested. Stack Overflow candidate labels Jan 29, 2019
@xinfli
Copy link
Author

xinfli commented Jan 30, 2019

Thanks all for your quick response 👍
I'd like if there is a new feature to mark message as read, by now I will hide it in our product :-)

@compulim
Copy link
Contributor

compulim commented Mar 6, 2020

This is done in 4.8.0.

@compulim compulim closed this as completed Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Out of scope for the current iteration but it will be evaluated in a future release. front-burner
Projects
None yet
Development

No branches or pull requests

7 participants