Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ReactWebChat] Markdown Base64 Images not getting rendered #1896

Closed
denscollo opened this issue Apr 12, 2019 · 4 comments · Fixed by #2067
Closed

[ReactWebChat] Markdown Base64 Images not getting rendered #1896

denscollo opened this issue Apr 12, 2019 · 4 comments · Fixed by #2067
Assignees
@denscollo
Labels
bug Indicates an unexpected problem or an unintended behavior. front-burner p0 Must Fix. Release-blocker
Projects
R8 Prioritization

Comments

@denscollo
Copy link
Contributor

Version

v4.3.0

Describe the bug

Marked down base64 encoded images not getting rendered. Instead shows the image caption.
We tested it on Azure Portal and HTML Sites (using also the example) and it works perfectly. When trying this approach on a React-App, using ReactWebChat, the images are not getting rendered.

Screenshots

Bot with Markdown Base64 image on Azure Portal Web Chat

imagen

Bot with MarkdownBase64 Image using ReactWebChat (on Chrome and Mozilla Firefox)

imagen
@denscollo denscollo mentioned this issue Apr 12, 2019
Closed
@corinagum corinagum added bug Indicates an unexpected problem or an unintended behavior. Triage-E labels Apr 15, 2019
@corinagum
Copy link
Contributor

@denscollo, thanks for filing this issue! If you have the time to do a PR with the fix, please feel free to do so! We appreciate your help.

@corinagum corinagum added needs-repro Waiting for repro or investigation 4.4 labels Apr 15, 2019
@corinagum
Copy link
Contributor

Investigate for 4.4

@cwhitten cwhitten removed the 4.4 label Apr 16, 2019
@corinagum corinagum added the backlog Out of scope for the current iteration but it will be evaluated in a future release. label Apr 16, 2019
@corinagum corinagum self-assigned this May 7, 2019
@corinagum corinagum added 4.5 front-burner and removed backlog Out of scope for the current iteration but it will be evaluated in a future release. needs-repro Waiting for repro or investigation labels May 7, 2019
@corinagum
Copy link
Contributor

@denscollo, could you tell me what format the data uri was in?

synk and the markdown-it security page indicate that only pngs, gifs, and jpgs are allowed in markdown-it.

@cwhitten cwhitten added the p0 Must Fix. Release-blocker label May 13, 2019
@corinagum corinagum moved this from P0 to In-Flight in R8 Prioritization May 14, 2019
@corinagum corinagum moved this from In-Flight to P0 in R8 Prioritization May 14, 2019
@corinagum corinagum removed their assignment May 15, 2019
@ParadoxARG
Copy link

Hi @corinagum, sorry for the delay. We were using pngs for our tests.

@cwhitten cwhitten added Southworks and removed 4.5 labels May 29, 2019
@cwhitten cwhitten moved this from P0 to In-Flight in R8 Prioritization Jun 5, 2019
@denscollo denscollo mentioned this issue Jun 10, 2019
Merged
@corinagum corinagum moved this from In progress to Done in R8 Prioritization Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denscollo denscollo

Labels
bug Indicates an unexpected problem or an unintended behavior. front-burner p0 Must Fix. Release-blocker
Projects
No open projects
R8 Prioritization
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add data schema to render base64 images microsoft/BotFramework-WebChat
4 participants
@cwhitten @corinagum @denscollo @ParadoxARG