Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlinks are opening in Web Chat. #454

Closed
gauravrattan1980 opened this issue May 10, 2017 · 27 comments
Closed

Hyperlinks are opening in Web Chat. #454

gauravrattan1980 opened this issue May 10, 2017 · 27 comments

Comments

@gauravrattan1980
Copy link

Hi All,

I am using Web Chat Channel with Microsoft Bot Framework and its opening Hyperlinks posted inside chat in Web Chat Channel itself.
Note: This functionality was working fine till yesterday and it was opening different browser window for hyperlinks posted inside chat. We are using this from last 1 month and it suddenly stops's working.

Please help?

Thanks
Gaurav

@danmarshall
Copy link
Contributor

Hi @gauravrattan1980 - thank you for reporting this. We recently switched markdown libraries, I'm suspecting this may be the cause. Are your links sent in markdown?

@gauravrattan1980
Copy link
Author

Yes you are correct. We have used markdowns for out hyperlinks...

Thanks
Gaurav

@gauravrattan1980
Copy link
Author

Can u give me idea, how long it will take to fix this issue.

Thanks in advance....

@danmarshall
Copy link
Contributor

I will be working on this quite soon :) are you building your own WebChat? Or are you retrieving botchat.js off a CDN ?

@gauravrattan1980
Copy link
Author

For our demo purpose, I have just enabled Web Chat channel from Microsoft Bot framework. In future we are thinking to build our own WebChat.

Thanks
Gaurav

@danmarshall
Copy link
Contributor

Hi Guarav - We should be deploying this sometime soon. Meanwhile I have sent a PR containing the fix #455

@gauravrattan1980
Copy link
Author

Thanks for your swift response...

@danmarshall
Copy link
Contributor

Hi Guarav, it may not be deployed until late tomorrow at the earliest, so can you please use a temporary workaround: shift-click the links. Sorry about the inconvenience.

@gauravrattan1980
Copy link
Author

Hi Dan,
Any idea when will above changes get deployed? Thanks...

@danmarshall
Copy link
Contributor

Hi @gauravrattan1980 - it should deploy on Monday. We did not want to deploy during //build

@gauravrattan1980
Copy link
Author

Any information on above issue??

@gauravrattan1980
Copy link
Author

Thx mate... It's working now...

@danmarshall
Copy link
Contributor

@GeekTrainer can we get a new npm package to close this issue?

@GeekTrainer
Copy link
Member

Just published.

@danmarshall
Copy link
Contributor

Hi @bramhechatejas thank you for reporting this. Can you please tell me how your WebChat is hosted? Is it an iframe of webchat.botframework.com or is it your own hosted WebChat page?

@danmarshall
Copy link
Contributor

@bramhechatejas are you using the "enable preview" option on the WebChat configuration page? If so, this may be the older WebChat control. Otherwise, can you provide a sample of the markdown with hyperlinks and can you tell me if it is on a card attachment or directly in the message?

@danmarshall
Copy link
Contributor

@bramhechatejas can you copy your markdown with the links so that we can reproduce the error? Or perhaps share your link?

@danmarshall
Copy link
Contributor

Hi @bramhechatejas thank you for that link. I was able to reproduce your error. Your bot was sending an html bit inside the message:

...In case of any queries <a href='https://www.gslab.com/'>Visit GS Lab</a>

the <a> tag should not be supported, we will need to disable this functionality. You can use markdown to enable this:

...In case of any queries [Visit GS Lab](https://www.gslab.com)

@billba
Copy link
Member

billba commented Jul 31, 2017

@bramhechatejas the actual bug here is that HTML tags should be ignored in the text. The only way your bot should communicate links is via Markdown syntax. This bug is being fixed (see #606) and once it's merged, if you don't change to Markdown syntax, your behavior will go from "links open in chat window" to "links don't work at all."

compulim pushed a commit to compulim/BotFramework-WebChat that referenced this issue Jul 14, 2018
@SwedhaBalasubramanian
Copy link

SwedhaBalasubramanian commented Feb 9, 2019

Is there a way how to include the hyperlink in Workplace/Facebook? Markdown is not working in Facebook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants
@GeekTrainer @billba @danmarshall @gauravrattan1980 @SwedhaBalasubramanian and others