New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
icu-intl: Ubuntu 14LTS build break #4664
Comments
http://bugs.icu-project.org/apiref/icu4c/ucurr_8h.html#acc9adb69459d712bc18e3e167dc5ec2a This is stable since 4.2. That is not the issue that was being experienced. |
Please provide more details to the issue and we could preferably use our cmake feature detection approach here to decide what to do. |
but... I am still highly unconvinced that this is a code issue. I will look into this more on Monday. |
As long as ‘default’ ChakraCore build successfully compiles and runs on 14LTS, there is no issue. Otherwise, API or ABI.. we have the tools to fix it. |
I was getting link errors after building CC with —embed-icu on Ubuntu 16.04, is this related? |
Do you remember what the link errors were? The error being discussed here was one that came up in the office, a compilation error about an undefined reference to ucurr_getPluralName_52 |
I don’t remember exactly, they were definitely ICU functions it was failing on though, I had to double check that I had passed |
Can you be more precise? This is a tested scenario by CI and it doesn't fail on neither 1.8 or master. |
I’ll verify later once I pull up my Ubuntu 16 VM. |
But later, attempting to link to the shared library:
|
Very interesting -- that is all stuff used by ICU internally, not by ChakraCore. There are lots of typeinfo issues, and I remember there were some issues related to RTTI in the past. The classes there also seem to be from all over the place (haven't looked specifically but some of these things look like theyre from both Common and i18n). Super bizarre that this is an issue, though, since this is what our CI tests. |
I'm building with |
So you get the error when you use the shared lib? |
@obastemur Yes, |
Can you please share some details on that? |
What more do you need to know? I run build.sh with |
The scenario you mentioned works on CI (test/native-tests/test-shared-basic). I'm trying to understand what is actually different with your build (CC linkage) |
If it helps at all, here's the relevant part of my makefile: Pretty standard stuff, I think. |
Also here's everything else I link to if it matters: |
@fatcerberus I got the same errors after building CC on a dirty out folder. Can you please clean build folder for CC and retry? |
@obastemur Thanks, just tried that about 5 minutes ago. I blew away my entire CC directory, cloned fresh from master and rebuilt with |
can you try the following;
|
|
Error code 126 means.. (among other things) it can't load It could be really nice if you may send a full raw log for the script below; (assuming you are under ~/src)
When I do this on various systems, it doesn't fail. |
@obastemur Still failing. 😭 Here's the full output running the exact commands you listed: |
Thanks! I will normalize the log you sent and compare to mine / CI.. lets see what’s going on |
@fatcerberus most likely there is no If there is;
What do you got? |
I just checked, the
|
I am going to assume this is resolved; feel free to re-open it in the future if something similar comes up. I am not sure if 14.04 works yet but at this point that should probably be a different issue if someone still wants it, and can probably be worked around with --embed-icu regardless. |
We have icu-intl is enabled by default now. ICU-intl impl. uses couple of ICU API those are not available on ICU 52. Although we don't say we officially support any of these, we could simply feature detect and pick API we can use and keep the number of platforms we support.
IMHO we shouldn't break our default build with Ubuntu 14LTS
The text was updated successfully, but these errors were encountered: