September 2018 Security Update #5688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes an issue where deepCopied arrays have a different inlined head segment behavior from its original instance. This is because deepCopy'ing an array would unconditionally allocate the head segment as inline, regardless of its size. This conflicts with JavascriptArray::HasInlineHeadSegment, which is based upon size rather than layout. In the PoC, this causes problems when removing elements via Slice. The fix is to clone the inlined behavior of the original instance in addition to the instance's data. This allows related invariants to be maintained. This change also ensures that the aligned, allocated size of the inline head segment on the stack is never larger than INLINE_CHUNK_SIZE, similarly to NewLiteral.
…ent check bypass - Google, Inc.
MikeHolman
requested review from
sigatrev,
meg-gupta,
Penguinwizzard,
pleath,
thomasmo and
rajatd
meg-gupta
approved these changes
Sep 11, 2018
sigatrev
approved these changes
Sep 11, 2018
thomasmo
approved these changes
Sep 11, 2018
rajatd
approved these changes
Sep 11, 2018
|
@dotnet-bot test this please |
chakrabot
pushed a commit
that referenced
this pull request
Sep 11, 2018
Merge pull request #5688 from MikeHolman:servicing/1809 September 2018 Security Update that addresses the following issues in ChakraCore: CVE-2018-8315 CVE-2018-8354 CVE-2018-8367 CVE-2018-8452 CVE-2018-8456 CVE-2018-8459 CVE-2018-8465 CVE-2018-8466 CVE-2018-8467
chakrabot
pushed a commit
that referenced
this pull request
Sep 11, 2018
Merge pull request #5688 from MikeHolman:servicing/1809 September 2018 Security Update that addresses the following issues in ChakraCore: CVE-2018-8315 CVE-2018-8354 CVE-2018-8367 CVE-2018-8452 CVE-2018-8456 CVE-2018-8459 CVE-2018-8465 CVE-2018-8466 CVE-2018-8467
chakrabot
pushed a commit
that referenced
this pull request
Sep 11, 2018
…curity Update Merge pull request #5688 from MikeHolman:servicing/1809 September 2018 Security Update that addresses the following issues in ChakraCore: CVE-2018-8315 CVE-2018-8354 CVE-2018-8367 CVE-2018-8452 CVE-2018-8456 CVE-2018-8459 CVE-2018-8465 CVE-2018-8466 CVE-2018-8467
This was referenced Nov 29, 2021
This was referenced Nov 29, 2021
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
September 2018 Security Update that addresses the following issues in ChakraCore:
CVE-2018-8315
CVE-2018-8354
CVE-2018-8367
CVE-2018-8452
CVE-2018-8456
CVE-2018-8459
CVE-2018-8465
CVE-2018-8466
CVE-2018-8467