This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
fix: bug 2356 #1404
Merged
fix: bug 2356 #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update train dialog validity flags on replay from train dialog list view
|
🎉 This PR is included in version 0.413.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mattmazzola
reviewed
Dec 5, 2019
| @@ -1071,6 +1071,21 @@ class TrainDialogs extends React.Component<Props, ComponentState> { | |||
| this.props.trainDialogReplayThunkAsync as any, | |||
| ) | |||
|
|
|||
| // Get new activities to check for errors or warnings | |||
| const teachWithActivities = ((await this.props.fetchActivitiesThunkAsync(this.props.app.appId, newTrainDialog, this.props.user.name, this.props.user.id) as any) as Promise<CLM.TeachWithActivities>) | |||
| const replayError = DialogUtils.getMostSevereReplayError((await teachWithActivities).activities) | |||
There was a problem hiding this comment.
It looks like you have incorrect await statement due to wrong types above. Either way two awaits is weird and wouldn't recommend this syntax in inline awaits
There was a problem hiding this comment.
Ugh.. Sloppy coding. thx
There was a problem hiding this comment.
Wow. It's vscode that stuck that in. I typed "a", TAB for auto-complete, and....
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update train dialog validity flags on replay from train dialog list view