Update barycentric with new spec #265
Conversation
|
@youngkim93, |
|
✅ Build DirectXShaderCompiler 1.0.91 completed (commit 6016fbd7c1 by @youngkim93) |
1. Adding SV_Barycentric and removing barycentric intrinsics/dxilops 2. GetAttributeAtVertex only thakes no_interpolation attribute 3. SV_Barycentric can take any interpolation modifier except nointerpolation
2. Fix Typo from SV_Barycentric to SV_Barycentrics
|
✅ Build DirectXShaderCompiler 1.0.95 completed (commit df401c02fe by @youngkim93) |
utils/hct/hctdb.py
Outdated
| @@ -1559,6 +1542,8 @@ def build_valrules(self): | |||
| self.add_valrule("Meta.ForceCaseOnSwitch", "Attribute forcecase only works for switch") | |||
| self.add_valrule("Meta.ControlFlowHintNotOnControlFlow", "Control flow hint only works on control flow inst") | |||
| self.add_valrule("Meta.TextureType", "elements of typed buffers and textures must fit in four 32-bit quantities") | |||
| self.add_valrule("Meta.BarycentricsInterpolation", "Invalid interpolation type '%0' for SV_Barycentrics. Interpolation type must be linear, linear noperspective, linear centroid, linear noperspective centroid, linear sample or linear noperspective sample") | |||
There was a problem hiding this comment.
This should use the add_valrule_msg function with separate summary line and message with %0 value. Also, since the only invalid enum here is Constant (nointerpolation), why not shorten the message to something like "SV_Barycentrics can not be used with interpolation type 'nointerpolation'" or something like that.
|
✅ Build DirectXShaderCompiler 1.0.99 completed (commit c10e1bf246 by @youngkim93) |
Note that the signature packing of SV_Barycentric is set to "Not Packed" for now. This could potentially change based on the feedback from hardware vendors.