Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GSL easier consumed by another project. #370

Closed
wants to merge 1 commit into from

Conversation

sezaru
Copy link

@sezaru sezaru commented Sep 20, 2016

This PR is related to this issue: #363

Changes:

  • Switched old include_directories function for the newer target_include_directories.
  • Added GSL as a INTERFACE library
  • Added GSL project to the tests CMakeLists.txt so It can include it automatically.

Changes:
- Switched old include_directories function for the newer target_include_directories.
- Added GSL as a INTERFACE library
- Added GSL project to the tests CMakeLists.txt so It can include it automatically.
@msftclas
Copy link

Hi @sezaru, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

@sezaru, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@sezaru
Copy link
Author

sezaru commented Sep 20, 2016

Just for completeness, travis-ci is failing because this change requires CMake 2.8.12 instead of 2.8.7.

@neilmacintosh
Copy link
Collaborator

@sezaru it looks as though this PR would need work to resolve conflicts before we could apply it (as well as ensuring our Travis used right version of CMake). Are you interested in reviving it?

@neilmacintosh
Copy link
Collaborator

Given we now have #467 which appears to build on the ideas of this PR, I'll close this one out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants