Enable code analysis all rules.

[XhmikosR]

Fixes #341

@whoisj: this isn't supposed to go in like that; check out my branch locally, run build with analysis, see which warnings you want disabled and push to my branch. When you are ready you can merge it :)

[XhmikosR]

I added a custom ruleset where we can disable rules globally. I went ahead and disable a few spelling ones. You can use that to disable more rules globally.

[whoisj]

Thanks for this. Please see the tip commit on https://github.com/whoisj/Git-Credential-Manager-for-Windows/tree/analysis-all-rules, I think that's what we need.

Did you want to cherry-pick my single commit, or have me create a PR with your commits. You've done the initial work, so I'll let you decide. 😄

[XhmikosR]

You don't need a new branch; you can push to my fork already. But if you decide to go with your approach a cherry pick would be preferable thanks.

…

On Jan 5, 2017 20:13, "J Wyman" ***@***.***> wrote: Thanks for this. Please see the tip commit on https://github.com/whoisj/Git-Credential-Manager-for- Windows/tree/analysis-all-rules, I think that's what we need. Did you want to cherry-pick my single commit, or have me create a PR with your commits. You've done the initial work, so I'll let you decide. 😄 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#350 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVVtbA6HXj0lsuLwCoTkV-WQo_OhN4jks5rPTLUgaJpZM4LbaLQ> .

[whoisj]

Ahh pushed then, thanks.

[XhmikosR]

@whoisj: wow, huge patch! Congrats!

BTW there are still a few errors https://ci.appveyor.com/project/whoisj/git-credential-manager-for-windows/branch/master/messages

On a side note, should we make the analyzer warnings fail the build or keep the current behavior?

[XhmikosR]

Also, might be worth moving the inline suppressions to the individual GlobalSuppressions.cs files so that everything is organized.

[whoisj]

keep the current behavior

Keep the current, I'd rather not have a broken build due to "style" issues.

moving the inline suppressions to the individual GlobalSuppressions.cs

I'm of two minds here, neither option is actually great. Local suppression is easier to understand, edit, update, remove, etc. Global suppression is cleaner read and easier to find what is suppressed.

[XhmikosR]

It's your call ofc, I just feel that having everything in one place might be better for organization.