This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
cli: add GCM_HTTP_TIMEOUT and httpTimeout support #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeschu1
added
enhancement
whoisj
approved these changes
Sep 21, 2018
| { | ||
| get | ||
| { | ||
| lock (_syncpoint) |
There was a problem hiding this comment.
So why the scoped format for the get and the inline format for the set?
Perhaps just make both inline?
get { lock (_syncpoint) return _requestTimeout; }
set { lock (_syncpoint) _requestTimeout = value; }
Make network connection time-out configurable. Provide a mechanism for setting `Global.RequestTimeout` via config or environment variables.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make network connection time-out configurable. Provide a mechanism for setting
Global.RequestTimeoutvia config or environment variables.resolves #733