Skip to content
This repository has been archived by the owner on Jul 30, 2022. It is now read-only.

Jan 2019 update #19

Merged
merged 24 commits into from
Jan 25, 2019
Merged

Jan 2019 update #19

merged 24 commits into from
Jan 25, 2019

Conversation

sdavis3
Copy link
Contributor

@sdavis3 sdavis3 commented Jan 19, 2019

resolves #12
resolves #16
resolves #17

@mwasham
Copy link
Contributor

mwasham commented Jan 19, 2019

Nice!
A few tweaks:

  • Rename the lab guide to HOL step-by-step - Continuous Delivery in Azure DevOps.md
  • Create a folder called archive in the hands-on lab folder and move the unguided lab guide to it.
  • Rename the WDS guide filenames using the new name as well.
  • The WDS PPTX is missing alt-text in the graphics
  • The common scenarios graphic in the WDS Trainer/Learner guide is the old VSTS image
  • Copyright dates in the MD should be updated to 2019

@DawnmarieDesJardins
Copy link
Contributor

@sdavis3
Hi Shane,
I see you've removed the VSTS from the title, but you left the "and Azure" making the new title Continuous Delivery in Azure DevOps and Azure. Please make a quick run through to make sure the title is correct in all the documents before we send this for SME review. Walter will be changing the repo title so links will change to match the new title.
Thanks!
Dawnmarie

@sdavis3
Copy link
Contributor Author

sdavis3 commented Jan 21, 2019

@DawnmarieDesJardins Thank you for catching those. I updated the pull request in addition to renaming the paths where VSTS was included. Also archived the unguided lab folder of images.

@DawnmarieDesJardins DawnmarieDesJardins requested a review from a team January 22, 2019 00:59

Duration: 15 Minutes

Tailspin Toys has asked you to create a continuous delivery process for their development team. To do that without disrupting their current production application, you are tasked with creating an environment in Azure where this new process and workflow can be proven. Your first task is to create a Visual Studio Team Services Team Project with Git source control where their source code can be maintained.
Tailspin Toys has asked you to create a continuous delivery process for their development team. To do that without disrupting their current production application, you are tasked with creating an environment in Azure where this new process and workflow can be proven. Your first task is to create an Azure DevOps Team Project with Git source control where their source code can be maintained.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not critical at this point, but going forward the term "Team Project" is renamed to "Project."
https://docs.microsoft.com/en-us/azure/devops/organizations/projects/about-projects?view=vsts&tabs=new-nav

@dmckinstry
Copy link

Overall I'm happy with it. Good job finding all the term renames... There is one that slipped by in some places: "Team Project" ==> "Project"

@sdavis3
Copy link
Contributor Author

sdavis3 commented Jan 22, 2019

I just pushed an update to the couple remaining references of "Team Project" to "Project".

@DawnmarieDesJardins DawnmarieDesJardins removed their request for review January 24, 2019 00:33
@DawnmarieDesJardins
Copy link
Contributor

@sdavis3 @mwasham @Jeff-Opsgility
Hello gentlemen, We have the approval needed to finalize this update. Please incorporate the feedback in the open issues, and close them out as appropriate. Once that's complete and documents have been edited, please let me know it's ready for QC/merge. Thanks, Dawnmarie

@sdavis3
Copy link
Contributor Author

sdavis3 commented Jan 24, 2019

To the best of my knowledge, the updates have been incorporated and the issues will automatically close when the code is merged. It's ready to be merged @DawnmarieDesJardins.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants