-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profiler doesn't like UTF8 BOM #663
Comments
We should use As part of a debugger refactor, we may be able to improve overlap with the profiler. |
I hit this too:
Sidenote: You're not using a
Eh? Is that a ancient-version-of-python-compatibility thing? |
Yes, we support back to Python 2.5 (which wasn't quite as ancient when that code was first written), and so we can't assume the It should certainly be in a try/finally though... |
Switches to using tokenize.open or tokenize.detect_encoding for reading source files.
Wow, I didn't realize that PTVS was that old! ...but the docs appear to say that the Also a side note: How many PTVS users actually use Python 2.5? |
It's available, but requires the use of a I suspect not many use Python 2.5 at this stage, but since we don't have to do much to keep supporting it we just keep it around. |
Ahh OK, that makes sense. I see that the fix is committed. When will it be available as an update? |
About the same time as VS 2015 Update 1 (though it'll be available for both VS 2013 and VS 2015, and we'll release a dev build and an RC sooner than that). |
That said, it's a pure-Python change (other than the test), so if you click through to the commit you can copy the contents of the Python files into your installed files and get the fix straight away. |
Switches to using tokenize.open or tokenize.detect_encoding for reading source files.
Example output of what happens when your startup file has a BOM and you start profiling:
The text was updated successfully, but these errors were encountered: