This repository has been archived by the owner on Dec 22, 2020. It is now read-only.
add dataset & scopes to token #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ranbreuer, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
yuryb2
reviewed
Jan 5, 2017
| @@ -87,3 +87,45 @@ The following decoded JSON web token | |||
| "nbf": 1360043456 | |||
| } | |||
| ``` | |||
|
|
|||
| ## Adding Permission Scopes to Embed Tokens | |||
| When using Embed tokens, one might want to restrict usage of the resources he gives access to. For this reason, you can generate a token with scoped permissions. | |||
There was a problem hiding this comment.
This is public documentation - do we need to review it with technical writers?
There was a problem hiding this comment.
we do, will do this as part of merge to master
yuryb2
reviewed
Jan 5, 2017
|
|
||
| if (datasetId) { | ||
| token.addClaim('did', datasetId); | ||
| } |
| @@ -34,6 +44,14 @@ export class PowerBIToken { | |||
| } | |||
| } | |||
|
|
|||
| if (scopes) { | |||
There was a problem hiding this comment.
reverting to defaults
yuryb2
approved these changes
Jan 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.