Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly coerce TargetPublishDate into ISO8601 prior to use in json #180

Merged

Conversation

riverar
Copy link
Contributor

@riverar riverar commented Oct 29, 2019

Resolves #179

@HowardWolosky
Copy link
Member

Per the comments I added in #179, I'm not able to repro this problem. Before I'd take a change to the code, I'd like to better understand why we're seeing a difference in behavior. I'm going to close this PR down for now and we can continue the discussion via #179 until such time as we understand why you're seeing this problem and we're not.

@riverar
Copy link
Contributor Author

riverar commented Aug 24, 2020

@HowardWolosky If you're starting to ramp up PowerShell Core support, you may want to revisit this PR.

Per #179 (comment), I suspect you're going to run into some date/time issues soon.

@HowardWolosky HowardWolosky reopened this Aug 24, 2020
@HowardWolosky
Copy link
Member

Thanks for reminding me about this, @riverar. At the time that you brought up these issues, I didn't have a good understanding of PowerShell Core and its future/direction. I've been working with it quite a bit over in PowerShellForGitHub lately, so now I just have my head wrapped around it better. Especially with the advent of GitHub Actions (which use PS Core), it makes a lot more sense now to make sure that this is working in all PS environments.

Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, @riverar! Much appreciated.
The same change needs to be made on the IAP side as well. Would you mind doing that as well? Then I can get this submitted and get a new version released.

I've confirmed that there aren't any other places that are similarly affected.

StoreBroker/PackageTool.ps1 Outdated Show resolved Hide resolved
StoreBroker/PackageTool.ps1 Outdated Show resolved Hide resolved
@riverar
Copy link
Contributor Author

riverar commented Aug 27, 2020

Just got the alert on this, oddly. Will get this done by EOB.

@HowardWolosky
Copy link
Member

Will get this done by EOB.

Thanks so much!

Copy link
Member

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks SO MUCH for catching the problem and submitting the fix! Much appreciated!

@HowardWolosky HowardWolosky merged commit 658cba6 into microsoft:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New-StoreBrokerConfigFile generates incorrect targetPublishDate value in PowerShell Core 6.2+
2 participants