V1 msix support #217
Merged
V1 msix support #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* AAA games use an .xvc package file format which is encrypted and thus can't be inspected for metadata properties. In these scenarios, we'll accept the format but disable trying to rename or add the additional metadata to the json (which effectively removes the ability to use -UpdatePackages during Update-Submission). * Fix bug with trying to use ConvertFrom-ExistingSubmission when there's only one listing (since `Get-Listing` would return a single item instead of an array, it didn't have a `Count` property and thus hit a divide-by-zero error when trying to display a status update). (cherry picked from commit 94d98df)
Additionally, making all `Test-Path` commands in PackageTool use `-ErrorAction Ignore` to avoid any erroneous errors being spit out from lack of file access. All we care about is getting a `$true` or `$false` result from those commands. (cherry picked from commit d7d1a4c)
Adds '.msixupload' to the list of extensions for files that should be able to be packaged but not inspected (for version numbers). This means that .msixupload files will not support the `-UpdatePackages` switch. (cherry picked from commit bc7396f)
…on package (microsoft#163) Currently, StoreBroker combines `.msix*` packages into `.json`/`.zip` pairs without inspecting the metadata within as it does for `.appx*` apps. This change will enable metadata inspection for `.msix`, `.msixbundle`, and `.msixupload` file extensions. This PR addresses issue microsoft#147 (for users using v2). - Created `New-SubmissionPackage` for `.appxbundle` with and without this change to verify no different in generated `.json` - Created `New-SubmissionPackage` for `.msixbundle` with this change and verified appropriate values were set (cherry picked from commit cf2379a)
(cherry picked from commit c414efd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds PackageTool support for the
msix*file extensions by cherry-picking the following commits from the v2 branch:94d98df
d7d1a4c
bc7396f
cf2379a
c414efd
This combination of commits does the following:
.msix,.msixbundle,.mxixuploadpackage file extensions.xvcfiles (Xbox packages). Submitting those packages using the v1 API however remains untested.Test-Pathcommands use-ErrorAction Ignoreto avoid any erroneous errors being reported due to lack of file access (all we care about is getting a$trueor$falseresponse from those function calls).Resolves #216