feat: .NET binding support #1156
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #1156 +/- ##
==========================================
- Coverage 83.72% 83.27% -0.46%
==========================================
Files 259 263 +4
Lines 12433 12744 +311
Branches 630 639 +9
==========================================
+ Hits 10410 10612 +202
- Misses 2023 2132 +109
Continue to review full report at Codecov.
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
core/src/main/scala/com/microsoft/azure/synapse/ml/param/ModelParam.scala
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| |} | ||
| |""".stripMargin | ||
| } | ||
| override private[ml] def dotnetGetter(capName: String): String = |
There was a problem hiding this comment.
Love that this was able to remove so much code!
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| Seq("dotnet", "pack", "--output", join(dotnetTestBaseDir, "target").getAbsolutePath), | ||
| dotnetTestBaseDir | ||
| ) | ||
| val packagePath = join(dotnetTestBaseDir, "target", s"SynapseML.DotnetE2ETest.0.9.1.nupkg").getAbsolutePath |
There was a problem hiding this comment.
Is this supposed to be 0.9.1? Seems hard-coded for debugging
There was a problem hiding this comment.
I fix this version on purpose, because the only change to the dotnetTestBase is the version of synapseml jar that it depends on. This is only used for our internal tests, so I'm open to either, releasing different snapshot versions is also fine.
Co-authored-by: Mark Hamilton <mhamilton723@gmail.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AB#1821715