chore: rename mmlspark to SynapseML #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhamilton723
requested review from
dbanda,
eisber,
imatiach-msft and
memoryz
as code owners
memoryz
requested changes
Oct 12, 2021
| ClassPath.from(getClass.getClassLoader) | ||
| .getResources.asScala.toList | ||
| .map(ri => className(ri.getResourceName)) | ||
| .filter(_.startsWith("com.microsoft.ml")) |
There was a problem hiding this comment.
Suggested change
| .filter(_.startsWith("com.microsoft.ml")) | |
| .filter(_.startsWith("com.microsoft.synapse.ml")) |
|
In AzureSearchWriter.py:
And there are a bunch of similar places. Just search for "jvm.com.microsoft.ml.spark". |
memoryz
requested changes
Oct 12, 2021
| |class $testClassName(unittest.TestCase): | ||
| | def assert_correspondence(self, model, name, num): | ||
| | model.write().overwrite().save(join(test_data_dir, name)) | ||
| | sc._jvm.com.microsoft.ml.spark.core.utils.ModelEquality.assertEqual( |
| |spark = (SparkSession.builder | ||
| | .master("local[*]") | ||
| | .appName("PysparkTests") | ||
| | .config("spark.jars.packages", "com.microsoft.ml.spark:mmlspark:" + __spark_package_version__) |
| val p2 = join(tmpDir.toString, "1_m2.model").toString | ||
| m1.write.overwrite().save(p1) | ||
| m2.write.overwrite().save(p2) | ||
| ModelEquality.assertEqual("com.microsoft.ml.spark.cognitive.TextSentiment", p1, p2) |
| this match { | ||
| case _: Estimator[_] => | ||
| val companionModelImport = companionModelClassName | ||
| .replaceAllLiterally("com.microsoft.ml.spark", "mmlspark") |
memoryz
reviewed
Oct 12, 2021
|
|
||
| test("Verify stage fitting and transforming") { | ||
| val exemptions: Set[String] = Set( | ||
| "com.microsoft.ml.spark.cognitive.DocumentTranslator", |
mhamilton723
force-pushed
the
rename-mmlspark
branch
from
d25f9e2
to
44402cd
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mhamilton723
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mhamilton723
force-pushed
the
rename-mmlspark
branch
from
1030f72
to
4118207
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Comment was made before the most recent commit for PR 1204 in repo microsoft/SynapseML |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mhamilton723
force-pushed
the
rename-mmlspark
branch
from
a598fa8
to
4232043
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mhamilton723
force-pushed
the
rename-mmlspark
branch
from
c8d2177
to
a0f5f8a
Compare
mhamilton723
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.