fix: lightgbm default params should not be specified if optional #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
imatiach-msft
force-pushed
the
ilmat/fix-optional-params
branch
from
93af9ca
to
7f170b0
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #1232 +/- ##
==========================================
- Coverage 83.69% 83.57% -0.13%
==========================================
Files 264 264
Lines 12911 12919 +8
Branches 637 634 -3
==========================================
- Hits 10806 10797 -9
- Misses 2105 2122 +17
Continue to review full report at Codecov.
|
imatiach-msft
force-pushed
the
ilmat/fix-optional-params
branch
from
cbb4bbe
to
c467335
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mhamilton723
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default params should not be specified if optional.
This PR fixes this issue by only passing the optional parameters to native lightgbm if they are explicitly specified.
Update: I thought this might be the cause of some issues with min_data_in_leaf and min_sum_hessian_in_lead but it doesn't seem to be the case. Regardless this seems like a good change to have, as we can't guarantee that specifying all possible parameters directly to lightgbm will lead to consistent behavior.