Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: min_data_in_leaf missing from dataset parameters in lightgbm #1239

Merged

Conversation

imatiach-msft
Copy link
Contributor

@imatiach-msft imatiach-msft commented Nov 3, 2021

fix performance issue when comparing lightgbm to MPI by adding missing min_data_in_leaf parameter to the set of dataset params used during dataset creation

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2021

Codecov Report

Merging #1239 (0b3080a) into master (5733b85) will decrease coverage by 0.67%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1239      +/-   ##
==========================================
- Coverage   83.57%   82.89%   -0.68%     
==========================================
  Files         264      248      -16     
  Lines       12919    11981     -938     
  Branches      634      631       -3     
==========================================
- Hits        10797     9932     -865     
+ Misses       2122     2049      -73     
Impacted Files Coverage Δ
...osoft/azure/synapse/ml/lightgbm/LightGBMBase.scala 94.88% <100.00%> (+0.02%) ⬆️
...ala/org/apache/spark/ml/param/EstimatorParam.scala 12.50% <0.00%> (-62.50%) ⬇️
...org/apache/spark/ml/param/JsonEncodableParam.scala 53.33% <0.00%> (-26.67%) ⬇️
...g/apache/spark/ml/param/PythonWrappableParam.scala 50.00% <0.00%> (-25.00%) ⬇️
...oft/azure/synapse/ml/codegen/GenerationUtils.scala 75.00% <0.00%> (-25.00%) ⬇️
...osoft/azure/synapse/ml/codegen/CodegenConfig.scala 66.66% <0.00%> (-14.82%) ⬇️
...ala/org/apache/spark/ml/param/DataFrameParam.scala 58.33% <0.00%> (-8.34%) ⬇️
...om/microsoft/azure/synapse/ml/onnx/ONNXModel.scala 8.88% <0.00%> (-2.71%) ⬇️
...c/main/python/synapse/ml/cyber/anomaly/__init__.py
...thon/synapse/ml/cyber/anomaly/complement_access.py
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5733b85...0b3080a. Read the comment docs.

@mhamilton723
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants