Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removing broadcast hint #1255

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Conversation

memoryz
Copy link
Contributor

@memoryz memoryz commented Nov 11, 2021

No description provided.

@memoryz
Copy link
Contributor Author

memoryz commented Nov 11, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2021

Codecov Report

Merging #1255 (76e7e55) into master (d8e64b3) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

❗ Current head 76e7e55 differs from pull request most recent head ca38e53. Consider uploading reports for the commit ca38e53 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1255      +/-   ##
==========================================
- Coverage   83.13%   82.93%   -0.21%     
==========================================
  Files         300      300              
  Lines       13699    13699              
  Branches      660      660              
==========================================
- Hits        11389    11361      -28     
- Misses       2310     2338      +28     
Impacted Files Coverage Δ
...t/azure/synapse/ml/explainers/KernelSHAPBase.scala 96.07% <100.00%> (ø)
...crosoft/azure/synapse/ml/explainers/LIMEBase.scala 98.18% <100.00%> (ø)
...e/ml/recommendation/RankingTrainValidationSplit.py 41.66% <0.00%> (-58.34%) ⬇️
...c/main/python/synapse/ml/nn/ConditionalBallTree.py 58.82% <0.00%> (-17.65%) ⬇️
...rc/main/python/synapse/ml/stages/UDFTransformer.py 45.45% <0.00%> (-15.16%) ⬇️
...recommendation/RankingTrainValidationSplitModel.py 81.81% <0.00%> (-9.10%) ⬇️
...crosoft/azure/synapse/ml/io/http/HTTPClients.scala 73.33% <0.00%> (-3.34%) ⬇️
.../execution/streaming/continuous/HTTPSourceV2.scala 92.80% <0.00%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8e64b3...ca38e53. Read the comment docs.

@memoryz
Copy link
Contributor Author

memoryz commented Nov 12, 2021

Fixes #1249

@memoryz
Copy link
Contributor Author

memoryz commented Nov 18, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@memoryz
Copy link
Contributor Author

memoryz commented Nov 18, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@memoryz memoryz marked this pull request as ready for review November 18, 2021 03:48
@memoryz
Copy link
Contributor Author

memoryz commented Nov 19, 2021

@mhamilton723 Mark the user has confirmed the fix works. Can you please merge the PR?

@memoryz memoryz added the rai Responsible AI label Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rai Responsible AI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Size of broadcasted table far exceeds estimates and exceeds limit of spark.driver.maxResultSize=4294967296.
3 participants