Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add multivariate anomaly detection #1272

Merged
merged 17 commits into from Dec 6, 2021

Conversation

serena-ruan
Copy link
Contributor

No description provided.

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2021

Codecov Report

Merging #1272 (4521bfb) into master (ff2aa02) will decrease coverage by 0.02%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1272      +/-   ##
==========================================
- Coverage   83.33%   83.30%   -0.03%     
==========================================
  Files         300      302       +2     
  Lines       13830    14021     +191     
  Branches      675      683       +8     
==========================================
+ Hits        11525    11680     +155     
- Misses       2305     2341      +36     
Impacted Files Coverage Δ
...se/ml/cognitive/MultivariateAnomalyDetection.scala 75.55% <75.55%> (ø)
...ure/synapse/ml/cognitive/FormOntologyLearner.scala 87.23% <100.00%> (+0.56%) ⬆️
...cognitive/MultivariateAnomalyDetectorSchemas.scala 100.00% <100.00%> (ø)
...osoft/azure/synapse/ml/core/utils/AsyncUtils.scala 65.00% <0.00%> (-5.00%) ⬇️
...zure/synapse/ml/stages/PartitionConsolidator.scala 93.61% <0.00%> (-2.13%) ⬇️
...e/src/main/python/synapse/ml/cognitive/__init__.py 100.00% <0.00%> (ø)
...ft/azure/synapse/ml/cognitive/ComputerVision.scala 79.59% <0.00%> (+0.51%) ⬆️
.../execution/streaming/continuous/HTTPSourceV2.scala 92.80% <0.00%> (+0.71%) ⬆️
...crosoft/azure/synapse/ml/io/http/HTTPClients.scala 85.00% <0.00%> (+11.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff2aa02...4521bfb. Read the comment docs.

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@serena-ruan serena-ruan marked this pull request as ready for review November 30, 2021 10:09
Copy link
Collaborator

@mhamilton723 mhamilton723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Only a few minor things

.setInputCol(getInputCol)
.setOutputCol(getOutputCol)
.setOntology(mergedSchema)
logFit({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)


def mad: MultivariateAnomalyModel = new MultivariateAnomalyModel()
.setSubscriptionKey(anomalyKey)
.setLocation("westus2")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do they have this service in eastus?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes they do, but our existing one is in westus2 so I just use it.

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants