Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support Math expressions in markdown doc #1278

Merged
merged 2 commits into from Dec 1, 2021

Conversation

memoryz
Copy link
Contributor

@memoryz memoryz commented Nov 30, 2021

Also did some reformatting for the data balance component.

@memoryz
Copy link
Contributor Author

memoryz commented Nov 30, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2021

Codecov Report

Merging #1278 (be22c18) into master (db03b01) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1278      +/-   ##
==========================================
- Coverage   83.14%   83.12%   -0.03%     
==========================================
  Files         300      300              
  Lines       13709    13709              
  Branches      656      656              
==========================================
- Hits        11399    11396       -3     
- Misses       2310     2313       +3     
Impacted Files Coverage Δ
...crosoft/azure/synapse/ml/io/http/HTTPClients.scala 76.66% <0.00%> (-6.67%) ⬇️
...osoft/azure/synapse/ml/core/utils/AsyncUtils.scala 70.00% <0.00%> (+5.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db03b01...be22c18. Read the comment docs.

@memoryz
Copy link
Contributor Author

memoryz commented Nov 30, 2021

Old:
image

New:
image

Copy link
Contributor

@serena-ruan serena-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the format!

Copy link
Collaborator

@mhamilton723 mhamilton723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@memoryz
Copy link
Contributor Author

memoryz commented Nov 30, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@ms-kashyap ms-kashyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks for making these changes Jason :)

@memoryz
Copy link
Contributor Author

memoryz commented Dec 1, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@memoryz
Copy link
Contributor Author

memoryz commented Dec 1, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@memoryz
Copy link
Contributor Author

memoryz commented Dec 1, 2021

@mhamilton723 can you help merge the change? It's blocked by some RTests failure which seems irrelevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants