Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Turned the Synapse tests into multiple test #1377

Merged
merged 18 commits into from
Feb 10, 2022
Merged

test: Turned the Synapse tests into multiple test #1377

merged 18 commits into from
Feb 10, 2022

Conversation

riserrad
Copy link
Contributor

@riserrad riserrad commented Feb 3, 2022

Overview

As of today, when running SynapseE2E tests, it runs in a single Scala test, which makes it harder to troubleshoot, especially given that this test runs multiple Synapse Spark Applications (Jobs).

This PR introduces a change that leverages the Scala ability to generate tests at runtime. With that, we will have one test per job submitted, making it easier to see which jobs failed from the Azure DevOps Pipeline run.

Changes

  • Made SynapseTests produce one test per notebook
  • Made DatabricksTests produce one test per notebook
  • Some code improvements
  • Minor tweaks to developer-readme.md

Result

Synapse Tests

image

Databricks Tests

image

Note: Databricks Tests contain 38 tests, so not all of them could be shown in the image above.

@riserrad
Copy link
Contributor Author

riserrad commented Feb 3, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2022

Codecov Report

Merging #1377 (32dbd9e) into master (2b08bd5) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1377      +/-   ##
==========================================
+ Coverage   84.72%   84.77%   +0.04%     
==========================================
  Files         287      287              
  Lines       14239    14250      +11     
  Branches      728      719       -9     
==========================================
+ Hits        12064    12080      +16     
+ Misses       2175     2170       -5     
Impacted Files Coverage Δ
...crosoft/azure/synapse/ml/io/http/HTTPClients.scala 73.33% <0.00%> (-1.67%) ⬇️
...cognitive/MultivariateAnomalyDetectorSchemas.scala 100.00% <0.00%> (ø)
...se/ml/cognitive/MultivariateAnomalyDetection.scala 88.83% <0.00%> (+0.46%) ⬆️
...zure/synapse/ml/stages/PartitionConsolidator.scala 95.74% <0.00%> (+2.12%) ⬆️
...soft/azure/synapse/ml/core/env/FileUtilities.scala 78.78% <0.00%> (+15.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3894c73...32dbd9e. Read the comment docs.

@riserrad
Copy link
Contributor Author

riserrad commented Feb 3, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@riserrad
Copy link
Contributor Author

riserrad commented Feb 3, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@riserrad
Copy link
Contributor Author

riserrad commented Feb 4, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@riserrad
Copy link
Contributor Author

riserrad commented Feb 4, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@riserrad
Copy link
Contributor Author

riserrad commented Feb 4, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@riserrad
Copy link
Contributor Author

riserrad commented Feb 4, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@riserrad
Copy link
Contributor Author

riserrad commented Feb 4, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@riserrad
Copy link
Contributor Author

riserrad commented Feb 4, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@riserrad
Copy link
Contributor Author

riserrad commented Feb 4, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@riserrad
Copy link
Contributor Author

riserrad commented Feb 4, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@riserrad riserrad marked this pull request as ready for review February 5, 2022 00:20
@riserrad riserrad changed the title Turned the Synapse tests into multiple test test: Turned the Synapse tests into multiple test Feb 5, 2022
mhamilton723
mhamilton723 previously approved these changes Feb 7, 2022
@riserrad
Copy link
Contributor Author

riserrad commented Feb 7, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@riserrad
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@riserrad riserrad merged commit 52b440c into microsoft:master Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants