Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove concurrency parameter for MVAD #1383

Merged
merged 4 commits into from
Feb 8, 2022

Conversation

serena-ruan
Copy link
Contributor

No description provided.

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2022

Codecov Report

Merging #1383 (b30f7fb) into master (9af38da) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1383      +/-   ##
==========================================
- Coverage   84.79%   84.69%   -0.10%     
==========================================
  Files         287      280       -7     
  Lines       14239    14104     -135     
  Branches      728      728              
==========================================
- Hits        12074    11946     -128     
+ Misses       2165     2158       -7     
Impacted Files Coverage Δ
...se/ml/cognitive/MultivariateAnomalyDetection.scala 88.37% <ø> (ø)
...org/apache/spark/ml/param/JsonEncodableParam.scala 53.33% <0.00%> (-26.67%) ⬇️
...crosoft/azure/synapse/ml/io/http/HTTPClients.scala 73.33% <0.00%> (-10.00%) ⬇️
...g/apache/spark/ml/param/PythonWrappableParam.scala 66.66% <0.00%> (-8.34%) ⬇️
...osoft/azure/synapse/ml/core/utils/AsyncUtils.scala 75.00% <0.00%> (-5.00%) ⬇️
...soft/azure/synapse/ml/cognitive/TextToSpeech.scala 84.84% <0.00%> (-3.04%) ⬇️
...oft/azure/synapse/ml/cognitive/TextAnalytics.scala 85.82% <0.00%> (-2.69%) ⬇️
.../azure/synapse/ml/cognitive/TextAnalyticsSDK.scala 86.01% <0.00%> (-1.40%) ⬇️
...ft/azure/synapse/ml/cognitive/ComputerVision.scala 73.04% <0.00%> (-1.31%) ⬇️
...ft/azure/synapse/ml/cognitive/FormRecognizer.scala 81.00% <0.00%> (-1.00%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e78f582...b30f7fb. Read the comment docs.

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@serena-ruan serena-ruan merged commit 2b08bd5 into microsoft:master Feb 8, 2022
@serena-ruan serena-ruan deleted the serena/fixMVAD branch February 8, 2022 08:59
serena-ruan added a commit to serena-ruan/SynapseML that referenced this pull request Feb 11, 2022
* remove concurrency parameter for MVAD

* fix: fix node-fetch version security & error in MVAD sample

Co-authored-by: Mark Hamilton <mhamilton723@gmail.com>
serena-ruan added a commit that referenced this pull request Feb 12, 2022
* revert: revert changes of spark 3.2

* fix: change azure-ai-textanalytics dependency to shaded jar and rename namespace to make it compatible with spark 3.1

* allow branch spark3.1 to trigger pipeline

* fix shaded jar

* fix fasterxml by adding it ahead of coreDependencies

* fix io.netty issue

* fix io.netty issue

* fix databricks conflicts

* fix libraries syntax

* exclude io.netty:netty-tcnative-boringssl-static

* update adbRuntime

* exclude org.antlr while installing libraries on dbx clusters

* fix adbruntime

* fix adbruntime

* fix adb runtime

* fix adb submit job error

* ignore geospatialServices notebooks for adb because adb 9.1 runtime doesn"t support sending http requests to them

* fix: Make SynapseE2E Tests work now with Spark 3.2 (#1362)

* Trying to use only pool with Spark 3.2

* Updating install instructions for synapse to use 0.9.4

* Changing syntax to grab ipynb files

* Line breaking to comply with styling

* Changing ipynb filter for windows

* Fixing string new line syntax

* Improvements to SynapseTests

* Adding more spark pools 3.2

* Adjusting list tests not to assert

* Improving dev doc, livyPayLoad

* Changing SynapseWS to mmlsparkppe

* Changing synapse URL to dogfood

* Removing dogfood from token acquisition

* Fixing exludes syntax

* Adding 2 more Apache Spark Pools

* Improving the developer docs

* Adjusting identation on developer-readme

* Bumping Synapse test timeout to 40 min

* Applying PR feedback

Co-authored-by: Serena Ruan <82044803+serena-ruan@users.noreply.github.com>

* change to spark3.1 pools

* add more spark pools

* Show detailed response of livy

* Update url cuz spark3.1 is in prod already

* Update SynapseTests.scala

* Update SynapseUtilities.scala

* fix: remove concurrency parameter for MVAD (#1383)

* remove concurrency parameter for MVAD

* fix: fix node-fetch version security & error in MVAD sample

Co-authored-by: Mark Hamilton <mhamilton723@gmail.com>

* fix: expose response error out for better debugging if the error is returned by http directly (#1391)

* merge `turn synapse tests into multiple test`

Co-authored-by: Ric Serradas <riserrad@microsoft.com>
Co-authored-by: Mark Hamilton <mhamilton723@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants