Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make repo mybinder.org compatible #1487

Merged

Conversation

ppruthi
Copy link
Contributor

@ppruthi ppruthi commented Apr 21, 2022

Summary

This PR adds configuration files to the repository to make it compatible to run jupyter notebooks on web UI via mybinder.

This PR also renames environment.yaml to environment.yml as that is what binder expects the name as and changes the references of said yaml in repository/docs.

Tests

Click the link to play with binder running notebooks with synapseML: mybinder - synapseML
TODO (In future PRs):

  • : Automate creation of binder images via CI
  • : Add binder badge to repository for repo users/contributors

Dependency chances

None.

AB#1758360

@ppruthi ppruthi changed the title Ms/ppruthi/make binder compatible feat: Make repo mybinder.org compatible Apr 21, 2022
@mhamilton723
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

mhamilton723
mhamilton723 previously approved these changes Apr 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2022

Codecov Report

Merging #1487 (5bbf930) into master (777c6c2) will decrease coverage by 1.65%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1487      +/-   ##
==========================================
- Coverage   84.48%   82.83%   -1.66%     
==========================================
  Files         295      288       -7     
  Lines       14786    14651     -135     
  Branches      701      701              
==========================================
- Hits        12492    12136     -356     
- Misses       2294     2515     +221     
Impacted Files Coverage Δ
...soft/azure/synapse/ml/cognitive/AudioStreams.scala 0.00% <0.00%> (-87.88%) ⬇️
...t/azure/synapse/ml/cognitive/SpeechToTextSDK.scala 16.47% <0.00%> (-74.12%) ⬇️
...crosoft/azure/synapse/ml/cognitive/SpeechAPI.scala 0.00% <0.00%> (-70.00%) ⬇️
...org/apache/spark/ml/param/JsonEncodableParam.scala 55.55% <0.00%> (-27.78%) ⬇️
...g/apache/spark/ml/param/PythonWrappableParam.scala 66.66% <0.00%> (-8.34%) ⬇️
...ft/azure/synapse/ml/core/env/StreamUtilities.scala 77.77% <0.00%> (-7.41%) ⬇️
...crosoft/azure/synapse/ml/io/http/HTTPClients.scala 69.11% <0.00%> (-7.36%) ⬇️
...re/src/main/python/synapse/ml/core/schema/Utils.py 67.10% <0.00%> (-5.27%) ⬇️
...soft/azure/synapse/ml/cognitive/TextToSpeech.scala 84.84% <0.00%> (-3.04%) ⬇️
...oft/azure/synapse/ml/cognitive/TextAnalytics.scala 86.59% <0.00%> (-2.69%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 777c6c2...5bbf930. Read the comment docs.

@ppruthi
Copy link
Contributor Author

ppruthi commented Apr 25, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ppruthi
Copy link
Contributor Author

ppruthi commented Apr 25, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723 mhamilton723 merged commit b4af035 into microsoft:master Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants