fix: chunksize parameter incorrectly specified during data copy #1490
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the chunksize being incorrectly specified during data copy in single dataset mode. This PR should resolve the user issue: #1478
Specifically, the chunk size for the features array was actually specified to be
num_cols * default_chunksize
, hence using just the default chunksize is incorrect during the data copy operation. The PR uses the chunksize retrieved from the array directly.Also, this PR removes the unused method
getNumRowsForChunksArray
.Tests
A test was added to validate that specifying different chunk size values should not have any impact on the model metrics. The chunk size is only for copying data and should not have any impact on the model's accuracy.
Dependency changes
There are no dependency changes in this PR.
AB#1761413