fix: Fix multiclass training with initial scores #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svotaw
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
svotaw
commented
Jun 12, 2022
lightgbm/src/main/scala/com/microsoft/azure/synapse/ml/lightgbm/dataset/DatasetAggregator.scala
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1526 +/- ##
==========================================
+ Coverage 84.36% 84.39% +0.02%
==========================================
Files 297 297
Lines 14912 14942 +30
Branches 718 728 +10
==========================================
+ Hits 12581 12610 +29
- Misses 2331 2332 +1
Continue to review full report at Codecov.
|
lightgbm/src/main/scala/com/microsoft/azure/synapse/ml/lightgbm/dataset/DatasetAggregator.scala
Outdated
Show resolved
Hide resolved
...src/test/scala/com/microsoft/azure/synapse/ml/lightgbm/split1/VerifyLightGBMClassifier.scala
Show resolved
Hide resolved
imatiach-msft
previously approved these changes
Jun 13, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lightgbm/src/main/scala/com/microsoft/azure/synapse/ml/lightgbm/dataset/DatasetAggregator.scala
Outdated
Show resolved
Hide resolved
…apseML into multiclass-init-score
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| }) | ||
| } | ||
|
|
||
| test("Verify chunked array transpose complex") { |
imatiach-msft
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The use of initial scores with multiclass training was not working. There was 1 test, but it was marked as "ignore" due to being flaky. In actuality, it only passed sometimes out of pure luck since there were several bugs.
Tests
I turned the test back on, although it is still flaky for some reason. Could use some advice on this. However, having traced through all the code underneath, we are now appropriately sending multiclass initial scores to LightGBM. One column is sent for every class, and it is transposed from row to column format.
Dependency changes
If you needed to make any changes to dependencies of this project, please describe them here.
AB#1827802