fix: Fix validation data creation for useSingleDataset mode #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #1527 +/- ##
==========================================
+ Coverage 82.84% 84.27% +1.42%
==========================================
Files 297 290 -7
Lines 14942 14819 -123
Branches 728 719 -9
==========================================
+ Hits 12379 12489 +110
+ Misses 2563 2330 -233
Continue to review full report at Codecov.
|
lightgbm/src/main/scala/com/microsoft/azure/synapse/ml/lightgbm/SharedState.scala
Outdated
Show resolved
Hide resolved
lightgbm/src/main/scala/com/microsoft/azure/synapse/ml/lightgbm/dataset/DatasetAggregator.scala
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lightgbm/src/main/scala/com/microsoft/azure/synapse/ml/lightgbm/dataset/DatasetAggregator.scala
Show resolved
Hide resolved
imatiach-msft
approved these changes
Jun 14, 2022
|
/azp run |
mhamilton723
approved these changes
Jun 14, 2022
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix validation Dataset creation in useSingleDataset mode. Due to shared code with the regular training Dataset, every partition tries to merge its data with the "single" executor Dataset. But for validation data, there is only 1 array of data, so this ends up duplicating it. This causes 2 problems:
Tests
The existing validation Dataset tests still pass.
Dependency changes
If you needed to make any changes to dependencies of this project, please describe them here.
AB#1828018