Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make style check verbose #1532

Merged

Conversation

ppruthi
Copy link
Contributor

@ppruthi ppruthi commented Jun 15, 2022

Summary

Style check currently fails without any verbosity on what line(s) need fixing. The developer will have no idea on what line(s) to fix unless he/she runs the black tool locally. Given we can show this on our checks in the pipeline, that would be useful for the developer.

Tests

With verbosity: ADO Pipeline link
Without verbosity: ADO Pipeline link

Dependency changes

None

AB#1832624

@ppruthi
Copy link
Contributor Author

ppruthi commented Jun 15, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022

Codecov Report

Merging #1532 (21d207c) into master (3e23f02) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1532      +/-   ##
==========================================
- Coverage   84.30%   84.29%   -0.02%     
==========================================
  Files         297      290       -7     
  Lines       14954    14819     -135     
  Branches      719      719              
==========================================
- Hits        12607    12491     -116     
+ Misses       2347     2328      -19     
Impacted Files Coverage Δ
...org/apache/spark/ml/param/JsonEncodableParam.scala 57.89% <0.00%> (-26.32%) ⬇️
...g/apache/spark/ml/param/PythonWrappableParam.scala 66.66% <0.00%> (-8.34%) ⬇️
...re/src/main/python/synapse/ml/core/schema/Utils.py 67.10% <0.00%> (-5.27%) ⬇️
...soft/azure/synapse/ml/cognitive/TextToSpeech.scala 84.84% <0.00%> (-3.04%) ⬇️
...oft/azure/synapse/ml/cognitive/TextAnalytics.scala 86.59% <0.00%> (-2.69%) ⬇️
.../azure/synapse/ml/cognitive/TextAnalyticsSDK.scala 86.01% <0.00%> (-1.40%) ⬇️
...ft/azure/synapse/ml/cognitive/FormRecognizer.scala 73.40% <0.00%> (-1.07%) ⬇️
...t/azure/synapse/ml/cognitive/BingImageSearch.scala 89.28% <0.00%> (-0.90%) ⬇️
.../microsoft/azure/synapse/ml/cognitive/OpenAI.scala 55.22% <0.00%> (-0.75%) ⬇️
...main/python/synapse/ml/io/http/JSONOutputParser.py
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e23f02...21d207c. Read the comment docs.

@ppruthi ppruthi self-assigned this Jun 16, 2022
@ppruthi ppruthi requested a review from serena-ruan June 16, 2022 18:21
@mhamilton723 mhamilton723 merged commit 1c1b2e1 into microsoft:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants