Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pre-commit first pass #1538

Merged

Conversation

ppruthi
Copy link
Contributor

@ppruthi ppruthi commented Jun 20, 2022

Summary

  • Code changes enforcing linting/style check appearing as a result of pre-commit run --all-files
  • Updated pre-commit to version 4.3.0
  • Add developer docs on using pre-commit

Tests

Running azp pipeline

Dependency changes

Add pre-commit as a python dependency

AB#1837989

@ppruthi
Copy link
Contributor Author

ppruthi commented Jun 20, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2022

Codecov Report

Merging #1538 (bf41ade) into master (9204586) will increase coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1538      +/-   ##
==========================================
+ Coverage   83.71%   83.81%   +0.10%     
==========================================
  Files         301      301              
  Lines       15337    15337              
  Branches      707      707              
==========================================
+ Hits        12839    12855      +16     
+ Misses       2498     2482      -16     
Impacted Files Coverage Δ
...zure/synapse/ml/cognitive/DocumentTranslator.scala 19.71% <ø> (ø)
...ft/azure/synapse/ml/cognitive/FormRecognizer.scala 74.46% <ø> (ø)
...synapse/ml/cognitive/TextAnalyticsSDKSchemas.scala 81.19% <ø> (ø)
...re/src/main/python/synapse/ml/core/schema/Utils.py 72.36% <ø> (ø)
...hon/synapse/ml/core/serialize/java_params_patch.py 94.02% <ø> (ø)
...ynapse/ml/cyber/anomaly/collaborative_filtering.py 90.98% <ø> (ø)
...thon/synapse/ml/cyber/anomaly/complement_access.py 96.15% <ø> (ø)
core/src/main/python/synapse/ml/cyber/dataset.py 94.11% <ø> (ø)
...c/main/python/synapse/ml/cyber/feature/indexers.py 92.18% <ø> (ø)
...rc/main/python/synapse/ml/cyber/feature/scalers.py 95.33% <ø> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9204586...bf41ade. Read the comment docs.

@ppruthi
Copy link
Contributor Author

ppruthi commented Jun 20, 2022

/azp run

2 similar comments
@ppruthi
Copy link
Contributor Author

ppruthi commented Jun 20, 2022

/azp run

@ppruthi
Copy link
Contributor Author

ppruthi commented Jun 20, 2022

/azp run

@ppruthi ppruthi enabled auto-merge (squash) June 20, 2022 21:25
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

2 similar comments
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ppruthi
Copy link
Contributor Author

ppruthi commented Jun 20, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723 mhamilton723 merged commit 3bd5bef into microsoft:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants