Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support gray scale images in toNDArray #1592

Merged
merged 5 commits into from Aug 3, 2022

Conversation

malihasameen
Copy link
Contributor

@malihasameen malihasameen commented Aug 2, 2022

Changed toNDArray method to also support converting gray scale images to numpy arrays for further transformations on those arrays.

AB#1909273

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

Hey @malihasameen 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.
We appreciate your patience and contributions 💯!

@mhamilton723
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

mhamilton723
mhamilton723 previously approved these changes Aug 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2022

Codecov Report

Merging #1592 (744be94) into master (51beaa0) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #1592   +/-   ##
=======================================
  Coverage   83.58%   83.59%           
=======================================
  Files         305      305           
  Lines       15795    15797    +2     
  Branches      752      752           
=======================================
+ Hits        13203    13206    +3     
+ Misses       2592     2591    -1     
Impacted Files Coverage Δ
.../main/python/synapse/ml/opencv/ImageTransformer.py 47.36% <0.00%> (-1.73%) ⬇️
...se/ml/cognitive/MultivariateAnomalyDetection.scala 87.03% <0.00%> (-0.75%) ⬇️
...oft/azure/synapse/ml/lightgbm/NetworkManager.scala 92.22% <0.00%> (+2.77%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mhamilton723
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

memoryz
memoryz previously approved these changes Aug 2, 2022
Copy link
Contributor

@memoryz memoryz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mhamilton723
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723 mhamilton723 merged commit e019756 into microsoft:master Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants