Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add aisample time series forecasting #1614

Merged
merged 2 commits into from
Aug 18, 2022
Merged

docs: add aisample time series forecasting #1614

merged 2 commits into from
Aug 18, 2022

Conversation

lhrotk
Copy link
Contributor

@lhrotk lhrotk commented Aug 15, 2022

Related Issues/PRs

None

What changes are proposed in this pull request?

Add time series forecasting notebook for aisample under notebooks/community/aisample.

How is this patch tested?

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.
  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder.
    Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

AB#1928947

@github-actions
Copy link

Hey @lhrotk 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.
We appreciate your patience and contributions 💯!

Copy link
Collaborator

@mhamilton723 mhamilton723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this great PR Cruise, it looks pretty tight! Leaving comments below

  1. It looks like there is a few thousand lines of data still in the notebook (see the raw representation) could you please remove this so we can have small diffs that are viewable in UX?
  2. Mentioned this to Tan too, if you want we can make this notebook run on all platforms by using the synapseml public blob to host data.

@lhrotk
Copy link
Contributor Author

lhrotk commented Aug 16, 2022

Thanks so much for your feedback, Mark. I have deleted redundant lines in notebook metadata and now it is comparable. I will discuss with him on making this notebook available to all platforms.

mhamilton723
mhamilton723 previously approved these changes Aug 17, 2022
@mhamilton723
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2022

Codecov Report

Merging #1614 (8ff0bf5) into master (7b4b0e1) will decrease coverage by 4.89%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1614      +/-   ##
==========================================
- Coverage   83.77%   78.87%   -4.90%     
==========================================
  Files         292      292              
  Lines       15473    15473              
  Branches      752      752              
==========================================
- Hits        12963    12205     -758     
- Misses       2510     3268     +758     
Impacted Files Coverage Δ
...synapse/ml/cognitive/TextAnalyticsSDKSchemas.scala 0.00% <0.00%> (-81.20%) ⬇️
...e/synapse/ml/cognitive/FormRecognizerSchemas.scala 7.69% <0.00%> (-76.93%) ⬇️
...ure/synapse/ml/cognitive/FormOntologyLearner.scala 14.28% <0.00%> (-73.47%) ⬇️
.../synapse/ml/cognitive/AnomalyDetectorSchemas.scala 33.33% <0.00%> (-66.67%) ⬇️
.../azure/synapse/ml/cognitive/TextAnalyticsSDK.scala 22.37% <0.00%> (-63.64%) ⬇️
...oft/azure/synapse/ml/cognitive/TextAnalytics.scala 31.67% <0.00%> (-54.59%) ⬇️
...ft/azure/synapse/ml/cognitive/TextTranslator.scala 33.08% <0.00%> (-48.13%) ⬇️
...osoft/azure/synapse/ml/core/utils/AsyncUtils.scala 35.00% <0.00%> (-40.00%) ⬇️
.../azure/synapse/ml/cognitive/AnomalyDetection.scala 40.00% <0.00%> (-40.00%) ⬇️
...t/azure/synapse/ml/cognitive/BingImageSearch.scala 57.14% <0.00%> (-32.15%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mhamilton723
Copy link
Collaborator

Traceback (most recent call last):
  File "/home/vsts/work/1/s/website/notebookconvert.py", line 65, in <module>
    main()
  File "/home/vsts/work/1/s/website/notebookconvert.py", line 61, in main
    convert_allnotebooks_in_folder(folder, outputdir)
  File "/home/vsts/work/1/s/website/notebookconvert.py", line 44, in convert_allnotebooks_in_folder
    os.mkdir(cur_output_dir)
FileNotFoundError: [Errno 2] No such file or directory: '/home/vsts/work/1/s/website/docs/community/aisamples'

@lhrotk, looks like we need to stop the notebook converter from picking this folder up. You think you have the cycles to try this fix? @serena-ruan will be able to advise on what needs to change here. You can repro this locally with the sbt convertNotebooks command i think

@serena-ruan
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@serena-ruan serena-ruan merged commit f54f7f6 into microsoft:master Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants