Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve test coverage #1631

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

mhamilton723
Copy link
Collaborator

@mhamilton723 mhamilton723 commented Aug 24, 2022

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Briefly describe the changes included in this Pull Request.

How is this patch tested?

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.
  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder.
    Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

AB#1946165

@mhamilton723
Copy link
Collaborator Author

/azp run

@github-actions
Copy link

Hey @mhamilton723 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.
We appreciate your patience and contributions 💯!

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2022

Codecov Report

Merging #1631 (fa5cd8c) into master (e700fd1) will decrease coverage by 1.60%.
The diff coverage is 98.52%.

@@            Coverage Diff             @@
##           master    #1631      +/-   ##
==========================================
- Coverage   83.24%   81.64%   -1.61%     
==========================================
  Files         287      287              
  Lines       15080    15104      +24     
  Branches      743      756      +13     
==========================================
- Hits        12554    12331     -223     
- Misses       2526     2773     +247     
Impacted Files Coverage Δ
...azure/synapse/ml/featurize/text/PageSplitter.scala 100.00% <ø> (+4.65%) ⬆️
...ft/azure/synapse/ml/cognitive/ComputerVision.scala 50.83% <50.00%> (-21.02%) ⬇️
...se/ml/cognitive/MultivariateAnomalyDetection.scala 88.70% <100.00%> (+3.22%) ⬆️
...ft/azure/synapse/ml/codegen/DefaultParamInfo.scala 96.77% <100.00%> (+1.42%) ⬆️
...microsoft/azure/synapse/ml/codegen/Wrappable.scala 100.00% <100.00%> (ø)
...ure/synapse/ml/recommendation/RankingAdapter.scala 96.61% <100.00%> (+11.42%) ⬆️
...zure/synapse/ml/stages/StratifiedRepartition.scala 96.87% <100.00%> (+6.25%) ⬆️
...om/microsoft/azure/synapse/ml/onnx/ONNXModel.scala 79.00% <100.00%> (+1.61%) ⬆️
...azure/synapse/ml/vw/VowpalWabbitInteractions.scala 94.28% <100.00%> (+2.85%) ⬆️
...e/synapse/ml/cognitive/FormRecognizerSchemas.scala 7.69% <0.00%> (-76.93%) ⬇️
... and 87 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mhamilton723
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723 mhamilton723 force-pushed the improve-codecov-2 branch 2 times, most recently from 0cbec5a to 10389a5 Compare August 24, 2022 19:59
@mhamilton723
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723 mhamilton723 merged commit 1381db5 into microsoft:master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants