Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix flaky translate tests #1643

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

serena-ruan
Copy link
Contributor

@serena-ruan serena-ruan commented Sep 7, 2022

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Briefly describe the changes included in this Pull Request.

How is this patch tested?

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.
  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder.
    Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

AB#1966811

@github-actions
Copy link

github-actions bot commented Sep 7, 2022

Hey @serena-ruan 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.
We appreciate your patience and contributions 💯!

@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2022

Codecov Report

Merging #1643 (61de0d7) into master (59a922b) will increase coverage by 4.60%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1643      +/-   ##
==========================================
+ Coverage   81.19%   85.79%   +4.60%     
==========================================
  Files         272      272              
  Lines       14230    14230              
  Branches      739      739              
==========================================
+ Hits        11554    12209     +655     
+ Misses       2676     2021     -655     
Impacted Files Coverage Δ
...rosoft/azure/synapse/ml/stages/EnsembleByKey.scala 85.91% <0.00%> (-1.41%) ⬇️
...re/synapse/ml/cognitive/CognitiveServiceBase.scala 80.53% <0.00%> (+4.02%) ⬆️
...ure/synapse/ml/io/http/SimpleHTTPTransformer.scala 95.38% <0.00%> (+6.15%) ⬆️
...oft/azure/synapse/ml/param/UntypedArrayParam.scala 59.37% <0.00%> (+6.25%) ⬆️
...om/microsoft/azure/synapse/ml/cognitive/Face.scala 81.37% <0.00%> (+15.86%) ⬆️
...crosoft/azure/synapse/ml/io/http/HTTPClients.scala 75.00% <0.00%> (+23.52%) ⬆️
...osoft/azure/synapse/ml/core/utils/AsyncUtils.scala 65.00% <0.00%> (+30.00%) ⬆️
...t/azure/synapse/ml/cognitive/BingImageSearch.scala 90.17% <0.00%> (+32.14%) ⬆️
.../microsoft/azure/synapse/ml/cognitive/OpenAI.scala 81.25% <0.00%> (+33.12%) ⬆️
...ft/azure/synapse/ml/cognitive/FormRecognizer.scala 85.10% <0.00%> (+35.10%) ⬆️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@serena-ruan serena-ruan changed the title fix flaky translate tests fix: fix flaky translate tests Sep 7, 2022
@serena-ruan
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@serena-ruan serena-ruan merged commit d751a52 into microsoft:master Sep 7, 2022
@serena-ruan serena-ruan deleted the serena/fixTest branch September 7, 2022 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants