Skip to content

Commit

Permalink
Merge pull request #331 from MarcCote/speedup_render
Browse files Browse the repository at this point in the history
Loading speedup: Avoid loading viewers unless required.
  • Loading branch information
MarcCote committed Nov 22, 2023
2 parents df4a201 + c477844 commit 612c589
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion scripts/tw-play
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def main():

agent.reset(env)
if args.viewer is not None:
from textworld.envs.wrappers import HtmlViewer
from textworld.envs.wrappers.viewer import HtmlViewer
env = HtmlViewer(env, port=args.viewer)

if args.mode == "human" or args.very_verbose:
Expand Down
1 change: 0 additions & 1 deletion textworld/envs/wrappers/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
# Licensed under the MIT license.


from textworld.envs.wrappers.viewer import HtmlViewer
from textworld.envs.wrappers.recorder import Recorder
from textworld.envs.wrappers.filter import Filter
from textworld.envs.wrappers.limit import Limit
Expand Down
2 changes: 1 addition & 1 deletion textworld/envs/wrappers/tests/test_viewer.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

from textworld.utils import make_temp_directory
from textworld.generator import compile_game
from textworld.envs.wrappers import HtmlViewer
from textworld.envs.wrappers.viewer import HtmlViewer
from textworld.render import get_webdriver


Expand Down
3 changes: 1 addition & 2 deletions textworld/generator/maker.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
from textworld.generator.game import GameOptions
from textworld.generator.game import Game, World, Quest, Event, EntityInfo
from textworld.generator.graph_networks import DIRECTIONS
from textworld.render import visualize
from textworld.envs.wrappers import Recorder


Expand Down Expand Up @@ -857,7 +856,7 @@ def render(self, interactive: bool = False):
:param filename: filename for screenshot
"""
game = self.build(validate=False)
return visualize(game, interactive=interactive)
return textworld.render.visualize(game, interactive=interactive)

def import_graph(self, G: nx.Graph) -> List[WorldRoom]:
""" Convert Graph object to a list of `Proposition`.
Expand Down

0 comments on commit 612c589

Please sign in to comment.