📝 Readme small updates and fixes #9
Conversation
README.md
Outdated
|
|
||
| First off, open terminal and `cd` to the `TicTacToe_JS` folder. Install dependencies in `package.json`. | ||
|
|
||
| ``` | ||
| ```js |
README.md
Outdated
|
|
||
| Before we dive into TypeScript adoption, let's take a look at the structure of the TicTacToe app. It contains a few components and looks like below with or without TypeScript. | ||
|
|
||
| ```html |
There was a problem hiding this comment.
This isn't supposed to be a code block. It's supposed to actually be html to render a centered image in the resulting page.
README.md
Outdated
| ``` | ||
| node ./node_modules/webpack/bin/webpack.js | ||
| ```sh | ||
| node ./node_modules/.bin/webpack |
There was a problem hiding this comment.
This is a substance change, but I'd maybe suggest npx webpack instead (this is pretty much npx's intended use, right)? Since this is likely platform-dependent (as the bin folder contains bat files among other things).
There was a problem hiding this comment.
Wesley, this will expect users to have NPM 5.2.*, well. The intent in the PR was just to shorten the webpack execution path. What do you think?
There was a problem hiding this comment.
eh? I don't think you can actually shorten it the way you did then, since node ./node_modules/.bin/webpack doesn't work (on any platform), since the .bin folder contents are shell scripts, not js:
And I think we're trying to avoid something complex like "invoke in whatever way is correct for your shell the script at ./node_modules/.bin/webpack", which could be just ./node_modules/.bin/webpack or & ./node_modules/.bin/webpack or a number of other things.
There was a problem hiding this comment.
You're correct (I've native PC matchine @work only). It works with npx tool. I'll add a line with a link to blog post what the npx tool is
Thanks!
There was a problem hiding this comment.
Done, rebased!
peterblazejewicz
force-pushed
the
update/readme
branch
from
c7913f0
to
63fb84d
Compare
- block codes - white space unification - headers are now grouped by level - minor typos - shortened direct webpack execution with npx tool
peterblazejewicz
force-pushed
the
update/readme
branch
from
63fb84d
to
f66eeff
Compare
Thanks!