Combine error tooltip with quick info #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zhengbli I like this one :D |
|
+1 :D |
| @@ -92,7 +92,7 @@ def escape_html(raw_string): | |||
|
|
|||
| Note: only use for short strings | |||
| """ | |||
| return raw_string.replace('&', '&').replace('<', '<').replace('>', ">") | |||
| return raw_string.replace('&', '&').replace('<', '<').replace('>', '>').replace('\n', '<br>').replace(' ', ' ') | |||
There was a problem hiding this comment.
Shouldn't this be <br />, not <br>?
There was a problem hiding this comment.
<br /> actually doesn't work, only <br> is working. This seems to be undocumented though
| if region.contains(pt): | ||
| error_text = text | ||
| break | ||
| for (region, text) in client_info.errors['semanticDiag']: |
There was a problem hiding this comment.
One problem I notice with this approach is that it only handles one error at a time. Also, it requires a full iteration of all the diagnostics. But we could fix this another time.
|
Looks good apart from what I can see (apart from nits). |
|
@zhengbli is it possible to combine TypeScript tooltip with SublimeLinter TSlint tooltip? In VS Code they are combined in one tooltip.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We learned from user feedback that the initial implementation of the inline error tooltip is annoying and gets in the way of typing. This PR changes the implementation to show the error tip during mouse hovering, which is the same behavior with VSCode and VS.
Now the quick info hover tooltip is combined with the error tooltip, so if there is no error in the position, only quick info should be shown:
otherwise both will be shown: