Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad sourcemap paths when using gulp to build Microsoft/TypeScript #11105

Closed
aozgaa opened this issue Sep 23, 2016 · 2 comments
Closed

Bad sourcemap paths when using gulp to build Microsoft/TypeScript #11105

aozgaa opened this issue Sep 23, 2016 · 2 comments
Labels
Infrastructure Issue relates to TypeScript team infrastructure

Comments

@aozgaa
Copy link
Contributor

aozgaa commented Sep 23, 2016

TypeScript Version: master -- commit 40327b

Tested on Ubuntu 16.04 and Win10.

From a commandline (copying the Microsft/TypeScript readme instructions):

git clone https://github.com/Microsoft/TypeScript.git
cd TypeScript
npm install -g gulp
npm install
gulp local

checking any of the *.js.map files in the built/local directory reveals that the path to the source files is truncated. From tsserver.js.map, for example, we have

Expected behavior:

Obtained by building with jake:

{"version":3,"file":"tsserver.js","sourceRoot":"","sources":["file:////home/arthur/TypeScript/src/compiler/types.ts","file:////home/arthur/TypeScript/src/compiler/performance.ts","file:////home/arthur/TypeScript/src/compiler/core.ts","file:////home/arthur/TypeScript/src/compiler/sys.ts",

...

Actual behavior:

Obtained by building with gulp:

{"version":3,"sources":["compiler/types.ts","compiler/performance.ts","compiler/core.ts","compiler/sys.ts","compiler/utilities.ts","compiler/diagnosticInformationMap.generated.ts","compiler/scanner.ts",

...

EDIT: clarifying sentence.

@aozgaa aozgaa added Bug A bug in TypeScript Infrastructure Issue relates to TypeScript team infrastructure labels Sep 23, 2016
@Igorbek
Copy link
Contributor

Igorbek commented Sep 26, 2016

+1, I had to edit them manually in order to be able to debug.

@mhegazy mhegazy removed the Bug A bug in TypeScript label Sep 29, 2016
@weswigham
Copy link
Member

The paths are correct nowadays (ofc, gulp is our only build tool now, it had to be fixed) - sourceRoot is "" and the paths all look like ../../src/compiler/core.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issue relates to TypeScript team infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants