Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intellisense space issue #12236

Closed
waderyan opened this issue Nov 14, 2016 · 8 comments
Closed

Intellisense space issue #12236

waderyan opened this issue Nov 14, 2016 · 8 comments
Assignees
Labels
Bug A bug in TypeScript VS Code Tracked There is a VS Code equivalent to this issue

Comments

@waderyan
Copy link

From @wallverb on November 10, 2016 14:25

  • VSCode Version: Code - Insiders 1.8.0-insider (a28dc215af3146d827d4b2f46a3191e2d487efde, 2016-11-10T07:05:12.185Z)
  • OS Version: Darwin x64 16.1.0

Steps to Reproduce:

Typescript file:

test()

/**
 * This
 * 
 * is a test
 */
function test() {

}

Notice how popup shows 'isa test' when you hover test() in first line:

image

Copied from original issue: microsoft/vscode#15300

@waderyan waderyan self-assigned this Nov 14, 2016
@waderyan
Copy link
Author

Hmm.. I can't reproduce. Anything special about your project?

@waderyan
Copy link
Author

From @wallverb on November 12, 2016 0:53

@waderyan

I just started vscode - no project and created Typescript file

7w5mmcamb0

Not sure if related - but I'm using Typescript 2.2.0-dev.20161111

@waderyan
Copy link
Author

Confirmed with 2.2.0-dev.20161111

@waderyan waderyan added VS Code Tracked There is a VS Code equivalent to this issue and removed intellisense labels Nov 14, 2016
@Knagis
Copy link
Contributor

Knagis commented Nov 17, 2016

I have the same issue when using typescript language service from node. Typescript version 2.1.1

The first space after a newline is always removed in the comment that is returned by signature.getDocumentationComment().

@Knagis
Copy link
Contributor

Knagis commented Nov 22, 2016

Is there any update on this bug? In our case it prevents us from updating our build tools to the new version as we are using the language service extensively.

@waderyan waderyan added the Bug A bug in TypeScript label Nov 28, 2016
@waderyan
Copy link
Author

@Knagis I have this tracked on our bug tracker. I do not believe any work has started in this area, but your comments are noted to make this a higher priority.

@Knagis
Copy link
Contributor

Knagis commented Dec 12, 2016

I spent some more time on this, found the problem and fixed it. Pull request with the fix: #12858

@Knagis
Copy link
Contributor

Knagis commented Dec 12, 2016

Working more with the new compiler I found additional related problem

/**
foo * bar
*/
var x = 1;

in this case the asterisk between foo * bar is omitted. I have modified the PR to include a fix for this as well.

sandersn added a commit that referenced this issue Dec 12, 2016
Fixed missing whitespace in jsDoc comments. Fixes #12236
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript VS Code Tracked There is a VS Code equivalent to this issue
Projects
None yet
Development

No branches or pull requests

2 participants