Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language services hard-codes newline to \r\n #1653

Closed
csnover opened this issue Jan 13, 2015 · 2 comments · Fixed by #1654
Closed

Language services hard-codes newline to \r\n #1653

csnover opened this issue Jan 13, 2015 · 2 comments · Fixed by #1654
Labels
Bug A bug in TypeScript Help Wanted You can do this

Comments

@csnover
Copy link
Contributor

csnover commented Jan 13, 2015

services/services.ts createCompilerHost function hardcodes getNewLine to "\r\n" instead of providing a way for the LanguageServiceHost to define it (or at least using ts.sys.newLine).

Refs #372.

@danquirk danquirk added the Bug A bug in TypeScript label Jan 13, 2015
@mhegazy mhegazy added this to the TypeScript 1.5 milestone Jan 13, 2015
@mhegazy mhegazy added the Help Wanted You can do this label Jan 13, 2015
@mhegazy mhegazy modified the milestones: Community, TypeScript 1.5 Jan 13, 2015
@nycdotnet
Copy link

@mhegazy Would you consider a PR to add this to tsc? We've gotten requests for this in grunt-ts, and we don't currently have a way to support it without tsc supporting it directly. Thanks.

@mhegazy
Copy link
Contributor

mhegazy commented Feb 16, 2015

We already have an issue for it #1693. Looks like we need a new compiler flag for it. PR welcomed. I have no good ideas for the name though... --newLine \n or --newLine CRLR / LR.

@mhegazy mhegazy removed this from the Community milestone Apr 26, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Help Wanted You can do this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants