Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es2018): add definition for Promise.prototype.finally #20411

Closed
benbraou opened this issue Dec 3, 2017 · 1 comment
Closed

feat(es2018): add definition for Promise.prototype.finally #20411

benbraou opened this issue Dec 3, 2017 · 1 comment
Labels
Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Good First Issue Well scoped, documented and has the green light Help Wanted You can do this Suggestion An idea for TypeScript
Milestone
TypeScript 2.7

Comments

@benbraou
Copy link
Contributor

benbraou commented Dec 3, 2017

Promise.prototype.finally (https://github.com/tc39/proposal-promise-finally) is now at stage 3

This issue is created to handle the addition of the corresponding definition.

This has been suggested by @mhegazy #20385 (comment)
@benbraou
Copy link
Contributor Author

benbraou commented Dec 3, 2017

I will provide a PR for this

@mhegazy mhegazy added Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Good First Issue Well scoped, documented and has the green light Help Wanted You can do this Suggestion An idea for TypeScript labels Dec 4, 2017
@mhegazy mhegazy added this to the Community milestone Dec 4, 2017
@mhegazy mhegazy mentioned this issue Dec 5, 2017
Closed
3 tasks
benbraou added a commit to benbraou/TypeScript that referenced this issue Dec 6, 2017
@benbraou
bug(esnext): add definition for promise.finally
e98f316 
Fixes microsoft#20411
@benbraou benbraou mentioned this issue Dec 6, 2017
Merged
benbraou added a commit to benbraou/TypeScript that referenced this issue Jan 2, 2018
@benbraou
bug(esnext): add definition for promise.finally
39a6c9f 
Fixes microsoft#20411
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Jan 4, 2018
@mhegazy mhegazy modified the milestones: Community, TypeScript 2.7 Jan 4, 2018
mhegazy pushed a commit that referenced this issue Jan 4, 2018
@benbraou @mhegazy
bug(esnext): add definition for promise.finally (#20511)
b36d614 
Fixes #20411
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Good First Issue Well scoped, documented and has the green light Help Wanted You can do this Suggestion An idea for TypeScript
Projects
None yet
Milestone
TypeScript 2.7
Development

No branches or pull requests
2 participants
@mhegazy @benbraou