Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec should say public, private and protected modifiers are not allowed to be used with rest parameter #2733

Closed
yuit opened this issue Apr 12, 2015 · 1 comment
Closed

Spec should say public, private and protected modifiers are not allowed to be used with rest parameter #2733

yuit opened this issue Apr 12, 2015 · 1 comment
Assignees
@ahejlsberg
Labels
Spec Issues related to the TypeScript language specification Won't Fix The severity and priority of this issue do not warrant the time or complexity needed to fix it
Milestone
TypeScript 1.8

Comments

@yuit
Copy link
Contributor

yuit commented Apr 12, 2015

Currently,
"
A parameter is permitted to include a public, private, or protected modifier only if it occurs in the parameter list of a ConstructorImplementation (section 8.3.1) and only if it doesn't specify a BindingPattern.
"
The spec should have additional specify that "...and only if it doesn't specify a BindingPattern and restParameter" as rest parameter is also included in ParameterList.
@mhegazy mhegazy added Bug A bug in TypeScript Spec Issues related to the TypeScript language specification labels Apr 13, 2015
@mhegazy mhegazy added this to the TypeScript 1.5 milestone Apr 13, 2015
@mhegazy mhegazy modified the milestones: TypeScript 1.5, TypeScript 1.5.1 Apr 23, 2015
@mhegazy mhegazy removed the Bug A bug in TypeScript label May 27, 2015
@mhegazy mhegazy modified the milestones: TypeScript 1.5.2, TypeScript 1.6 Jun 17, 2015
@mhegazy mhegazy modified the milestones: TypeScript 1.7, TypeScript 1.8 Oct 9, 2015
@ahejlsberg
Copy link
Member

The grammar already reflects that accessibility modifiers aren't permitted on rest parameters. I don't think we need to add more wording.

@ahejlsberg ahejlsberg added the Won't Fix The severity and priority of this issue do not warrant the time or complexity needed to fix it label Dec 21, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ahejlsberg ahejlsberg

Labels
Spec Issues related to the TypeScript language specification Won't Fix The severity and priority of this issue do not warrant the time or complexity needed to fix it
Projects
None yet
Milestone
TypeScript 1.8
Development

No branches or pull requests
3 participants
@yuit @ahejlsberg @mhegazy