Normalize slashes for paths in watch events #57968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheetalkamat
requested review from
DanielRosenwasser,
andrewbranch and
jakebailey
jakebailey
approved these changes
Mar 27, 2024
|
@typescript-bot cherry-pick to release-5.4 |
|
Hey, @DanielRosenwasser! I was unable to cherry-pick this PR. Check the logs at: https://github.com/microsoft/TypeScript/actions/runs/8458595699 |
| @@ -93,8 +93,8 @@ describe("unittests:: tsserver:: events:: watchEvents", () => { | |||
| function updateFileOnHost(session: TestSession, file: string, log: string, content?: string) { | |||
| // Change b.ts | |||
| session.logger.log(`${log}: ${file}`); | |||
| if (content) session.host.appendFile(file, content); | |||
| else session.host.writeFile(file, session.host.readFile("/user/username/projects/myproject/a.ts")!); | |||
| if (content && session.host.fileExists(file)) session.host.appendFile(file, content); | |||
There was a problem hiding this comment.
I know this is just testing, but is there technically an issue here with if content is an empty string?
There was a problem hiding this comment.
yeah but its for testing so just simplified it
|
@DanielRosenwasser conflict for picking up comes because #57967 is not merged |
|
@typescript-bot cherry-pick to release-5.4 |
typescript-bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
|
Hey, @DanielRosenwasser! I've created #57970 for you. |
DanielRosenwasser
pushed a commit
that referenced
this pull request
Mar 28, 2024
…e-5.4 (#57970) Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.