Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go-to-definition doesn't work on path in calls to 'require' #9251

Closed
DanielRosenwasser opened this issue Jun 19, 2016 · 1 comment
Closed
Assignees
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue VS Code Tracked There is a VS Code equivalent to this issue

Comments

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Jun 19, 2016

./foo.js:

module.exports = {};

./bar.js:

var x = require(/*$*/"./foo");
  1. Go to definition on /*$*/

Expected: Navigate to foo.js.
Actual: Nada.

@DanielRosenwasser DanielRosenwasser added Bug A bug in TypeScript Salsa labels Jun 19, 2016
@mhegazy mhegazy added this to the TypeScript 2.1 milestone Jun 28, 2016
@mhegazy
Copy link
Contributor

mhegazy commented Jun 28, 2016

@riknoll has been looking at similar issues with completions in require call. moving to his plate.

@mhegazy mhegazy assigned sheetalkamat and unassigned riknoll Sep 29, 2016
@waderyan waderyan added the VS Code Tracked There is a VS Code equivalent to this issue label Sep 29, 2016
sheetalkamat added a commit that referenced this issue Oct 4, 2016
This helps in getting the alias symbol so that it can go to the definition of external module
Fixes #9251
sheetalkamat added a commit that referenced this issue Oct 6, 2016
This helps in getting the alias symbol so that it can go to the definition of external module
Fixes #9251
@sheetalkamat sheetalkamat added the Fixed A PR has been merged for this issue label Oct 6, 2016
sheetalkamat added a commit that referenced this issue Oct 6, 2016
This helps in getting the alias symbol so that it can go to the definition of external module
Fixes #9251
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue VS Code Tracked There is a VS Code equivalent to this issue
Projects
None yet
Development

No branches or pull requests

5 participants