Have classic module resolution use @types as a fallback #11147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
ghost
force-pushed
the
classic_at_types
branch
from
462f49a
to
9c26278
Compare
ghost
force-pushed
the
classic_at_types
branch
2 times, most recently
from
8c28901
to
957faff
Compare
ghost
force-pushed
the
classic_at_types
branch
from
957faff
to
4907fd1
Compare
vladima
approved these changes
Oct 6, 2016
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11103
This solution is to try loading from
@typesat the end ofclassicNameResolverfor global modules if all else failed.I do think that
typingsLookupAmd.trace.jsonis overly long. We climb up to the root of the file system before trying@types. This problem arises because for any target other than commonJS we default to "classic" resolution (moduleResolution = getEmitModuleKind(compilerOptions) === ModuleKind.CommonJS ? ModuleResolutionKind.NodeJs : ModuleResolutionKind.Classic;); it seems like people could be surprised if they switch their emit to ES6 modules and suddenly can't import their packages any more.