Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow export default interface. Related to issue 3792. #16040

Merged
merged 6 commits into from
May 23, 2017
Merged

Allow export default interface. Related to issue 3792. #16040

merged 6 commits into from
May 23, 2017

Conversation

mhegazy
Copy link
Contributor

@mhegazy mhegazy commented May 23, 2017

Continue on #15076, partially fixes #3792.

This adds handling for interface as export default target in resolveName, and updates tests.

@mhegazy mhegazy mentioned this pull request May 23, 2017
Closed
@mhegazy
Copy link
Contributor Author

mhegazy commented May 23, 2017

@andy-ms mind taking another look.

@mhegazy mhegazy merged commit 5ef6192 into master May 23, 2017
@mhegazy mhegazy deleted the exportDefaultInterface branch May 23, 2017 20:40
@mhegazy
Copy link
Contributor Author

mhegazy commented May 23, 2017

thanks @erikmcc

@mhegazy mhegazy mentioned this pull request May 23, 2017
Open
@alangpierce alangpierce mentioned this pull request Dec 28, 2017
Closed
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot 'export default' abstract, ambient class or interface
3 participants
@mhegazy @msftclas @erikmcc