Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile errors in tsbuildWatchMode.ts #27870

Merged
4 commits merged into from Oct 16, 2018
Merged

Fix compile errors in tsbuildWatchMode.ts #27870

4 commits merged into from Oct 16, 2018

Conversation

ghost
Copy link

@ghost ghost commented Oct 12, 2018

For some reason, this compile error only appears when running gulp runtests-browser but not jake.
core is explicitly defined to have 2 or 4 elements, so accessing 3 elements is suspect -- so adding TODO comments.

@sheetalkamat
Copy link
Member

Don't need todo. It is correct. Just ! is enough.

@weswigham
Copy link
Member

The issue also occurs when doing a nightly build, which means it's caused by an LKG/using the built compiler probably.

@ghost ghost merged commit eb2297d into master Oct 16, 2018
@ghost ghost deleted the corebang branch October 16, 2018 19:28
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants