Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DropShadowPanel should listen to SizeChanged events on its casting element #1111

Closed
seanmcr opened this issue Apr 19, 2017 · 1 comment
Closed

Comments

@seanmcr
Copy link

seanmcr commented Apr 19, 2017

Today it's possible for the DropShadowPanel's Content/casting element to change sizes without triggering an update to the shadow size...for instance, consider a DropShadowPanel whose HorizontalContentAlignment is set to Left, and then sometime later its HorizontalContentAlignment is changed to Stretch. In that case, the content's size will change, but DropShadowPanel.SizeChanged might not fire.

It seems just listening to the SizeChanged event on the casting FrameworkElement is the right thing to do, since the shadow's dimensions need to be updated any time the casting element's dimensions change.

@nmetulev
Copy link
Contributor

Hey @seanmcr, could you share a repro of this behavior?

hermitdave added a commit that referenced this issue Jul 11, 2017
Wire up DropShadowPanel Content's size change to ensure that shadow is updated correctly.
Address #1111 and #1299
@ghost ghost locked as resolved and limited conversation to collaborators Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants